How Do I Mute Rolltracker For Other Players?

Language: JP EN DE FR
New Items
2023-11-19
users online
Forum » Windower » Support » How do i mute Rolltracker for other players?
How do i mute Rolltracker for other players?
 Asura.Iamarealgirl
Offline
Server: Asura
Game: FFXI
user: Latravant
Posts: 79
By Asura.Iamarealgirl 2020-01-27 15:02:34
Link | Quote | Reply
 
i've been playing cor for a few months now and its been annoying to see my screen fly by as i use a roll just as someone else/a trust does and then i cant even tell what my roll was. is there anyway to disable the rolltracker chat log for others' rolls?
Offline
Posts: 35422
By fonewear 2020-01-27 15:12:38
Link | Quote | Reply
 
Easy hit the mute button.
 Sylph.Theodren
Offline
Server: Sylph
Game: FFXI
user: theodren
Posts: 26
By Sylph.Theodren 2020-01-27 16:01:07
Link | Quote | Reply
 
I modified my local copy of rolltracker.lua for this very reason. Around line 178, inside the register_event function and after the rollActor variable is assigned, I added the following:

Code
if rollActor ~= player.id then
  return
end


Fair warning that this will get blown away if rolltracker gets an update and you'll have to reapply it.
 Asura.Iamarealgirl
Offline
Server: Asura
Game: FFXI
user: Latravant
Posts: 79
By Asura.Iamarealgirl 2020-01-27 22:37:56
Link | Quote | Reply
 
thank you
 Bismarck.Xurion
Offline
Server: Bismarck
Game: FFXI
user: Xurion
Posts: 693
By Bismarck.Xurion 2020-01-28 02:07:45
Link | Quote | Reply
 
Sylph.Theodren said: »
I modified my local copy of rolltracker.lua for this very reason. Around line 178, inside the register_event function and after the rollActor variable is assigned, I added the following:

Code
if rollActor ~= player.id then
  return
end


Fair warning that this will get blown away if rolltracker gets an update and you'll have to reapply it.
You should submit that change as a PR. The addon readme states it tracks your roll numbers.

Even better, allow the user to configure it to show only their own rolls or all rolls.
 Asura.Chiaia
VIP
Offline
Server: Asura
Game: FFXI
user: Demmis
Posts: 1652
By Asura.Chiaia 2020-01-28 03:29:18
Link | Quote | Reply
 
Bismarck.Xurion said: »
You should submit that change as a PR. The addon readme states it tracks your roll numbers.
Please don't submit a PR that changes how something has worked for years. Unless it's a cleaner implementation of it.

Bismarck.Xurion said: »
Even better, allow the user to configure it to show only their own rolls or all rolls.
Now this is fine but it should by default work how it has and have the option to opt in to the change. There are sometimes reasons to not follow this rule.
[+]
 Bismarck.Xurion
Offline
Server: Bismarck
Game: FFXI
user: Xurion
Posts: 693
By Bismarck.Xurion 2020-01-28 06:48:23
Link | Quote | Reply
 
Asura.Chiaia said: »
Bismarck.Xurion said: »
You should submit that change as a PR. The addon readme states it tracks your roll numbers.
Please don't submit a PR that changes how something has worked for years. Unless it's a cleaner implementation of it.

Bismarck.Xurion said: »
Even better, allow the user to configure it to show only their own rolls or all rolls.
Now this is fine but it should by default work how it has and have the option to opt in to the change. There are sometimes reasons to not follow this rule.
I agree, backwards compatibility breaks/unexpected changes in functionality are bad - I made the PR suggestion due to the readme technically being inconsistent with what the addon actually does. But a PR for correcting the readme is probably an easier fix XD

I should have caveated my post with a suggestion to first have a conversation about any changes to addons with people in the Windower Discord, to save you time (and tears) in the long run.
necroskull Necro Bump Detected! [1040 days between previous and next post]
Offline
Posts: 214
By zigzagzig 2022-12-03 05:50:36
Link | Quote | Reply
 
For a Simple Rolltracker log line in:

Rolltracker.lua at 222 , : windower.add_to_chat(1, chat.controls.reset..' '..chars.implies..' '..rollInfo[rollID][1]..' Roll '..chars['circle' .. rollNum]..luckChat..string.char(31,13)..' (+'..rollBonus..')'..BustRate(rollNum, rollActor)..ReportRollInfo(rollID, rollActor))
Log in to post.